Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text vertically overlaps in dialogs #126

Closed
6 tasks done
inexorabletash opened this issue Feb 7, 2019 · 8 comments
Closed
6 tasks done

Text vertically overlaps in dialogs #126

inexorabletash opened this issue Feb 7, 2019 · 8 comments
Assignees
@inexorabletash
Labels
bug DeskTop DeskTop bugs or feature requests
Milestone
1.2

Comments

@inexorabletash
Copy link
Collaborator

inexorabletash commented Feb 7, 2019 •
edited
Loading

The default font is 9px high, but dialogs use 8px spacing. This leads to clipped descenders if strings are drawn top-to-bottom.

draw_dialog_label is the biggest offender, but the Format/Erase drive selection is also afflicted.

To fix, everything needs to do proper math rather than 3 shifts.

  • About
  • Format / Erase
  • Confirmation/progress: copy/move/delete/lock/unlock
  • Pick Selector Entry
  • File browser (Add/Edit Selector Entry, Copy/Move file)
  • Selector (the app)
@inexorabletash inexorabletash added bug DeskTop DeskTop bugs or feature requests labels Feb 8, 2019
@inexorabletash inexorabletash self-assigned this Feb 8, 2019
inexorabletash added a commit that referenced this issue Feb 9, 2019
@inexorabletash
Adjust vertical spacing in various dialogs (Issue #126)
e92822e 
* About
* Confirmation and progress dialogs (copy/delete/lock/unlock etc)
* Format/Erase disk
inexorabletash added a commit that referenced this issue Feb 10, 2019
@inexorabletash
Adjust vertical spacing in Selector Entry picker (Issue #126)
2546a63
@inexorabletash
Copy link
Collaborator Author

About before:
image

and after:
image

@inexorabletash
Copy link
Collaborator Author

Format/Erase before:
image

and after:
image

@inexorabletash
Copy link
Collaborator Author

inexorabletash commented Feb 17, 2019 •
edited
Loading

Confirm before:
image

and after:
image

@inexorabletash
Copy link
Collaborator Author

Select Entry before:
image

and after:
image

inexorabletash added a commit that referenced this issue Feb 17, 2019
@inexorabletash
Fix progress/confirmation dialog clearing rects. Issue #126
ad75a61
@inexorabletash
Copy link
Collaborator Author

File selector:

image

(Note the overlaps in the radio buttons, and the items in the scrolling pane only get 8px each)

inexorabletash added a commit that referenced this issue Feb 25, 2020
@inexorabletash
DeskTop: Remove text overlaps in Add/Edit an Entry dialog. Issue #126
3c13c79
inexorabletash added a commit that referenced this issue Feb 25, 2020
@inexorabletash
DeskTop: Remove text overlaps in Add/Edit an Entry dialog. Issue #126
ddaae95
@inexorabletash
Copy link
Collaborator Author

image

Overlapping radio buttons fixed. Items in the scroll pane are still 8px tall

inexorabletash added a commit that referenced this issue Dec 31, 2020
@inexorabletash
Selector: Prevent vertical text overlaps. For #126
50569dd 
Entry row height was 8px, but the font is 9px tall. Use mul/div
functions and do it right. Also adjust the dialog positions
slightly and correct hit testing.
@inexorabletash
Copy link
Collaborator Author

Before:

image

After:

image

@inexorabletash
Copy link
Collaborator Author

Before:

image

After:

image

@inexorabletash inexorabletash added this to the 1.2 milestone Aug 17, 2021
c0mmander8 referenced this issue Sep 4, 2021
@inexorabletash
More release note/test plan tweaks c/o @c0mmander8
cce9aa4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@inexorabletash inexorabletash

Labels
bug DeskTop DeskTop bugs or feature requests
Projects
None yet
Milestone
1.2
Development

No branches or pull requests
1 participant
@inexorabletash