Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Arrow keypress select the next item in the respective direction #274

Closed
c0mmander8 opened this issue Sep 15, 2020 · 1 comment
Closed
Labels
DeskTop DeskTop bugs or feature requests feature request User-facing feature additions/enhancements
Milestone

Comments

@c0mmander8
Copy link
Contributor

Make Arrow keypress select the next item in the respective direction, just like the later Mac and the later IIGS.

@c0mmander8 c0mmander8 added DeskTop DeskTop bugs or feature requests feature request User-facing feature additions/enhancements labels Sep 15, 2020
@inexorabletash
Copy link
Collaborator

I did some exploration of this. The Apple-H mode which allows you to highlight icons works in a fascinating way. It grabs icons from the current active window and desktop volume icons, then bubble sorts them (by Y then X) into a list. The left/right arrow keys then let you navigate the list. This made more sense before I made icons variable height, since it sorts by the top of the icon, not the "baseline" of the icon. Also, it's only one dimensional - only left/right arrows do anything.

In contrast, on modern macOS Finder (for comparison), left/right/up/down all work, but it is constrained to the holder of the active selection (either a window or the desktop) it seems to be truly two dimensional using some fun heuristics. The up arrow literally select the next icon directly above the current icon. If you arrange icons in a diagonal line, you can't move between them. If you arrange icons in interesting patterns you can end up with the up arrow taking one path and the down arrow taking another path entirely.

I'm tempted to remove the Apple-H mode entirely and just have left/right cycle through next/prev icon (in file order) regardless of position, scrolling the window (if necessary) and cycling from window icons to desktop icons and back. But that's a lot of work.

inexorabletash added a commit that referenced this issue Nov 17, 2020
Apple-H shortcut is removed.

Left/Right (or Up/Down) icons cycle selected icon. Icons in the cycle
include visible icons in the active window (if any) and the desktop
(volume) icons. Order is based on icon creation order, not visual
order.
inexorabletash added a commit that referenced this issue Nov 22, 2020
Using arrow keys to select icon within window/desktop is no longer
limited to visible icons; the window will scroll as needed.

Scrolling up does not ensure the whole icon is visible; that will be a
follow-up.
@inexorabletash inexorabletash added this to the 1.2 milestone Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DeskTop DeskTop bugs or feature requests feature request User-facing feature additions/enhancements
Projects
None yet
Development

No branches or pull requests

2 participants