feat(draft-pr): add new option to not process PRs which are in draft #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
very much looking forward to this! |
|
up |
luketomlinson
approved these changes
Sep 17, 2021
There was a problem hiding this comment.
💥 I like it @C0ZEN. Left one minor comment. There's some merge conflicts too.
| // Delete the branch on closed pull request | ||
| private async _deleteBranch(issue: Issue): Promise<void> { | ||
| const issueLogger: IssueLogger = new IssueLogger(issue); | ||
|
|
||
| issueLogger.info(`Delete branch from closed $$type - ${issue.title}`); | ||
|
|
||
| const pullRequest = await this._getPullRequest(issue); | ||
| const pullRequest: IPullRequest | undefined | void = |
There was a problem hiding this comment.
I don't think you have to specify the type here. Could just do const pullRequest = await this._getPullRequest(issue)
There was a problem hiding this comment.
FYI: I do this on purpose because I prefer explicit types; easier to review and code IMO
C0ZEN
force-pushed
the
feature/ignore-draft-pr
branch
from
25ee4b6
to
cbb0ffc
Compare
|
Ready |
|
@C0ZEN thank you! @luketomlinson main branch hasn't tagged yet with new release, latest is v4.0.0 from July https://github.com/actions/stale/releases/tag/v4.0.0 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Context
Closes #36 (even if already closed).
See #36 (comment).