Document Problem Matcher Commands #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericsciple
reviewed
Nov 6, 2019
docs/problem-matchers.md
Outdated
| "owner": "eslint-compact", | ||
| "pattern": [ | ||
| { | ||
| // The pattern that provides groups to match against |
There was a problem hiding this comment.
comments are not legal JSON
There was a problem hiding this comment.
we shouldnt suggest customers use them, if it we switch to a different json parser in the future, it might break.
ericsciple
reviewed
Nov 6, 2019
ericsciple
reviewed
Nov 6, 2019
ericsciple
reviewed
Nov 6, 2019
ericsciple
reviewed
Nov 6, 2019
ericsciple
approved these changes
Nov 6, 2019
ericsciple
reviewed
Nov 6, 2019
ericsciple
reviewed
Nov 6, 2019
|
|
||
| The following fields are available for problem matchers: | ||
|
|
||
| ``` |
There was a problem hiding this comment.
a little bit weird since this isnt valid json
might be interesting to see how vscode docs describe it
There was a problem hiding this comment.
They put comments in the json
https://code.visualstudio.com/docs/editor/tasks#_defining-a-problem-matcher
There was a problem hiding this comment.
fails in nodejs: JSON.parse('{\n// this is a comment\n"a": "b" }')
not sure we should encourage this, binds us to a particular parser
ericsciple
reviewed
Nov 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendered
Resolves #56