Better Artifact Telemetry + Increase Upload chunk size #535
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When making any http calls during artifact upload or download, the user-agent string can be used to help differentiate between http-calls that get logged as part of internal telemetry. This PR changes the user-agent string to
@actions/artifact-upload
for any call that gets made during artifact upload and@actions/artifact-download
for any call that gets made during download.I really wanted to leverage the package version from
package.json
and then have the user-agent string be something like@actions/artifact-0.3.2-upload
however there are a host of issues reading the version number frompackage.json
since it's not included in therootDir
folder. More information here: https://stackoverflow.com/a/53836076I'm also bumping up the upload chunk size from 4MB to 8MB to help improve artifact upload in GHES scenarios