Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react to OIDC service change. #893

Merged
merged 5 commits into from
Aug 26, 2021

Conversation

TingluoHuang
Copy link
Member

No description provided.

@TingluoHuang TingluoHuang requested a review from a team as a code owner August 25, 2021 20:40
@TingluoHuang TingluoHuang requested a review from a team August 25, 2021 20:43
@@ -47,17 +38,14 @@ export class OidcClient {
if (!runtimeUrl) {
throw new Error('Unable to get ACTIONS_ID_TOKEN_REQUEST_URL env variable')
}
return `${runtimeUrl}?api-version=${OidcClient.getApiVersion()}`
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACTIONS_ID_TOKEN_REQUEST_URL will include ?api-version=2.0

Copy link
Collaborator

@thboop thboop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TingluoHuang TingluoHuang merged commit 5c3e1c2 into features/oidcpreview Aug 26, 2021
@TingluoHuang TingluoHuang deleted the users/tihuang/oidcupdate branch August 26, 2021 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants