Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

StringMatch utility should add weighting to exact prefix matches over separated matches. #3411

Closed
petetronic opened this issue Apr 11, 2013 · 6 comments
Assignees
Milestone

Comments

@petetronic
Copy link
Contributor

Add two files in the project root:

ASC.js
ActionScriptCompiler.js

While editing in some other file, open Cmd-T to access the Quick Open feature. Delete the @ sign if present, and then type "ASC".

It finds both ActionScriptCompiler.js and ASC.js, but ranks ActionScriptCompiler.js higher when it should probably prefer the exact match prefix for ASC.js at the top of the list.

@njx
Copy link
Contributor

njx commented Apr 18, 2013

Reviewed. Marking low priority, but @dangoor or @pfarland, feel free to bump it up if you think it's more important as we're not clear on how frequently people will hit this.

@petetronic
Copy link
Contributor Author

It now shows up in code hints proposals (because we're now using StringMatch utils for that too), so I think that makes it higher priority.

@dangoor
Copy link
Contributor

dangoor commented Apr 19, 2013

I do think this makes a difference for code hinting. I'm going to bump it to medium priority to ensure that we get across the board good results with the new hinting. I don't think there's a lot of effort involved, so I've also slotted it in for this sprint.

dangoor added a commit that referenced this issue Apr 19, 2013
This is a fix for #3411 and is going to be useful for code hinting
@dangoor
Copy link
Contributor

dangoor commented Apr 19, 2013

I've put up a pull request that boosts prefix matches and I think will generally make the heuristic better.

@njx
Copy link
Contributor

njx commented Apr 21, 2013

Marking fix in progress

@dangoor
Copy link
Contributor

dangoor commented Apr 24, 2013

With the landing of #3493, this is now fixed. I just verified using the case presented in the description (which is now also part of the stringmatch test suite)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants