Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

[Brackets 34] [acorn issue] #6022

Closed
iog-io opened this issue Nov 17, 2013 · 8 comments
Closed

[Brackets 34] [acorn issue] #6022

iog-io opened this issue Nov 17, 2013 · 8 comments

Comments

@iog-io
Copy link

iog-io commented Nov 17, 2013

Jum to definition (Ctrl-J) doesn't work either.

brackets34

@ghost ghost assigned dangoor Nov 18, 2013
@dangoor
Copy link
Contributor

dangoor commented Nov 18, 2013

This looks like it might be related to #5847 . Were you switching between an image preview and a JavaScript file by any chance? Do you have any more hints as to what you were doing when this bug came up?

@iog-io
Copy link
Author

iog-io commented Nov 18, 2013

This issue might be a false positive error. I've just tried to open this script http://userscripts.org/scripts/review/183145 and it has some images encoded which caused the problem.

@dangoor
Copy link
Contributor

dangoor commented Nov 19, 2013

@hoanglienson That looks like valid JavaScript, though. There are certain cases that can trip up the JavaScript parser, and being able to identify those helps us fix them.

I just tried pasting that particular script into the Tern demo page and it didn't seem to have a problem with it.

@iog-io
Copy link
Author

iog-io commented Nov 19, 2013

You're right, Tern seems not to have any problem with that script. Do you think Tern might use another parser version than Brackets 34. I've tried to comment those hardcoded images out but still have those parsing errors. I admit that I'm getting to familiar with JavaScript and dont know much about this language yet. If there's any chance I can help to tackle this just tell me, I will try my best. It's a good opportunity for me to learn more about JavaScript too.

@dangoor
Copy link
Contributor

dangoor commented Nov 19, 2013

No problem, I appreciate the help in identifying the case that's causing you an issue. I can try it in Brackets as well to see if it causes a problem for me there. I checked Tern/Acorn about 2 weeks back and there hadn't been many changes that would make a difference.

@dangoor
Copy link
Contributor

dangoor commented Nov 21, 2013

This should be fixed by #6068

@iog-io
Copy link
Author

iog-io commented Nov 21, 2013

You're right. In the folder that I placed the script does have other binary files as well. I now understand that's why you and Tern didn't have issue by reading the script but only me. Thanks for the fix. 👍

@dangoor
Copy link
Contributor

dangoor commented Nov 21, 2013

@hoanglienson I'm glad that my guess worked out! Thanks for the confirmation

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants