This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Filter out dotfiles in code hints #6068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -908,7 +908,6 @@ define(function (require, exports, module) { | |||
| } | |||
| } else { | |||
| return !isDirectoryExcluded(entry.fullPath) && | |||
| entry.name.indexOf(".") !== 0 && | |||
There was a problem hiding this comment.
This part of the patch seems to make one of the tests weaker. Was that intentional?
… within isFileExcluded for wider coverage
|
I've pushed another commit to this branch that implements a fix discussed with @gruehle:
Over to @gruehle for review. |
ghost
assigned 
| @@ -206,8 +206,13 @@ define(function (require, exports, module) { | |||
| if (!excludes) { | |||
There was a problem hiding this comment.
If excludes is null in the prefs, we won't exclude any file. I think this if statement needs to be moved into the code below so we will always do the dotfile and language checks.
|
Fixed. |
|
I verified that this fixes the hang/crash on Windows and all unit tests pass. I also did some light scenario testing with code hints and everything worked as expected. Merging |
gruehle
added a commit
that referenced
this pull request
Nov 20, 2013
Filter out dotfiles in code hints
|
Awesome. Thanks for the quick fixing and review @iwehrman, @gruehle and @peterflynn |
gruehle
added a commit
that referenced
this pull request
Dec 3, 2013
Filter out dotfiles in code hints
Merged
This was referenced Aug 30, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick fix for #6067, but this may not be the total fix if we want to filter out more than dotfiles