-
Notifications
You must be signed in to change notification settings - Fork 7.6k
[UX] Inactive panel gets dimmed in split view in release v1.0 #9785
Comments
Do you find the inactive pane content difficult to read for both light and dark themes? I don't mind the dimming for light themes, but imho it is a little bit excessive for dark themes - perhaps opacity For reference, this change came in with #9560. |
I'm using Monokai Dark Soda, a dark theme. I'm also working in an office with large windows, the dimming probably isn't a problem for those who are working in a workplace with less light. Also depends on the character of the monitor being used I guess. If there would be an option in the menu, where users could set the opacity (or disable it completetly), that would work for all I guess. In my case, where I'm writing css on one side, and reading the html structure on the other, I would prefer no dimming at all. |
I agree with this. I use a dark theme, and it makes the out of focus panel hard to read. I like the idea, but not the current implementation. Other ideas for this: Edit: I switched to default dark theme and the effect works much better, maybe all theme authors have to update their designs? Maybe add tags to all extensions? would make easier to get witch extension is updated/tested for new version |
@MikeSpock @ArgTang Themes are extensible, so the solution for now is to create your own Theme. |
I like the idea of having a preference for this. No other editor that I know of dims the text of inactive panes, so it may be pretty tough to get used to for some users. |
This definitely should be an option. When I'm using the split view, that means I want to reference both files at the same time. This is difficult to do if it's very dark. It's obvious enough where the cursor is if you have the line highlight enabled. +1 |
@redmunds the problem is the dimming itself - not the themes in my opinion. Obviously, dimming makes it more difficult to read text in any theme. |
Forked @stowball's extension to restore opacity. |
FWIW, I personally would rather see that header change color than to dim the text. It's a design decision that was made and implemented as part of the default Brackets Themes, so I just wanted to let everyone know that it can be changed in a custom Theme. |
You added this natively in b19cd4d? Ha. I agree with @MikeSpock, that it should be completely customisable (whether it happens at all, and the opacity that it sets), because this is a very personal choice |
If it is theme dependent it should only be applied when theme chooses to, not by default (imo) As i said before I like the idea, but maybe find another way to focus current work space would be better. |
Simple and a lot of demand for this -- adding Release 1.1. |
@placegraphichere We want to roll back the opacity so that it's 100% all the time and let users install @stowball Zen Pane if they want to change to 70%. This means that we may need to tweak the styles for the inactive/active panel to show state in light and dark modes. |
That sounds like a plan @JeffryBooher. As others mentioned, it would be best to do in conjunction with another visual affordance for the active/inactive panel. |
Here is a quick idea for switching panels. It should be compatible with themes, it is simply applying a quick (editable) animation to the active panel, and increased dimming the panel header text. https://www.dropbox.com/s/k7u1mrayacvnmav/panel-switch-effect-01.mov?dl=0 |
@placegraphichere I like the idea of some smooth animation, but personally, I'd rather leave the panel content out of it. It is my personal opinion that the editor area which is in the very focus of the users' attention, should not flicker or change in looks when focus comes and goes. Think about it: when switching panels, the user's eyes are already focused on the inactive panel. It seems redundant to have the panel make the click more clear that just happened. I think it would bring no value for the user. I'd find it a bit annoying if I wanted to select a text from the inactive panel, and while dragging the selection, the panel would flicker. I'd work with the panel header text as you mentioned. Code editors (webstorm, sublime, etc) solved this problem many times before, and somehow they all ended up using the panel header and maybe the panel frame's border color for indicating which panel is active. I think it would be an approach that would probably fit all, and we should go with that. While my suggestion is more conservative - or as some would righteously say straight boring -, innovation which doesn't boost productivity should be best left out from a code editor. What do you think? Good job though, I like the animation in its own ;) |
We discussed this again in review today and here's what we want to do:
|
@peterflynn +1 I like that idea. I'd rather install an extension dim the pane rather than undim it. |
…rk themes. Bug: #9785 [UX] Inactive panel gets dimmed in split view in release v1.0
@peterflynn Please review |
Closing -- this will be fixed in 1.2 per my comment above. Please let us know if you have any more feedback. |
This isn't necessarily a bug, but definitely a usability issue. Split view is often used when you want to read one code and write the other. The inactive panel gets dimmed which makes the content hard to read.
This is especially bad when you want to use Brackets in a strongly lit enviroment.
The text was updated successfully, but these errors were encountered: