Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Fix Korean translation of split-view menu items #10477

Merged
merged 1 commit into from
Mar 3, 2015

Conversation

mixed
Copy link
Contributor

@mixed mixed commented Jan 28, 2015

The CMD_SPLITVIEW_VERTICAL is up/down split but The (left/right) is understandable.
For example, Japanese is not a up/down but a left/right.

//current
"CMD_SPLITVIEW_VERTICAL"    : "위/아래로 분할",
"CMD_SPLITVIEW_HORIZONTAL"  : "왼쪽/오른쪽으로 분할",

//propose
"CMD_SPLITVIEW_VERTICAL"    : "왼쪽/오른쪽으로 분할",
"CMD_SPLITVIEW_HORIZONTAL"  : "위/아래로 분할",

//japanese==propose
"CMD_SPLITVIEW_VERTICAL": "左右分割",
"CMD_SPLITVIEW_HORIZONTAL": "上下分割",

@nethip
Copy link
Contributor

nethip commented Feb 10, 2015

@mixed you mentioned above that

//japanese==propose
"CMD_SPLITVIEW_VERTICAL": "左右分割",
"CMD_SPLITVIEW_HORIZONTAL": "上下分割"

is Japanese. When I punched this into google translate, google is saying detected lanugage is Chinese. Am I misunderstanding something here.

And also could you have someone do a linguistic review for this change?

@peterflynn
Copy link
Member

@mixed So if I understand correctly, you're proposing to just swap the strings for CMD_SPLITVIEW_VERTICAL and CMD_SPLITVIEW_HORIZONTAL? The tricky part is that both strings are actually ambiguous: does "up and down split" mean the splitter line is vertical (creating left & right panels), or the layout is vertical (top & bottom panels)? Either meaning could be misinterpreted by some people. The icons in the UI hopefully make it more clear what each string means.

I'm also a little worried it could be confusing to reverse the meaning of the two strings months after the original meaning shipped in a build...

Would a native speaker like @revi or @taggon or @ds5apn like to weigh in?

@taggon
Copy link
Contributor

taggon commented Feb 24, 2015

@peterflynn the both strings should be swapped. @mixed is right.

@revi
Copy link
Contributor

revi commented Feb 24, 2015

@mixed is correct, +1 as well.

@peterflynn
Copy link
Member

Thanks for the confirmation!

peterflynn added a commit that referenced this pull request Mar 3, 2015
Fix Korean translation of split view menu items (they were reversed)
@peterflynn peterflynn merged commit dd27cf9 into adobe:master Mar 3, 2015
@peterflynn peterflynn changed the title Korean: Translation Propose Fix Korean translation of split-view menu items Mar 3, 2015
@revi revi mentioned this pull request May 25, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants