-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Switch "Brackets" to "{APP_NAME}" in strings #10934
Conversation
Nice catch! Thank you! This looks good! I'm not merging this only because I'm not sure where in the release cycle we are. |
Agreed, great catch @dvorapa. I think we're all set to merge this since it's a pull request against the release branch. The only thing I'm not sure about is the impact on translations. Once we get the final translations we should do a scrub to make sure we're using @nethip do you know what the best way to handle this is? |
This is why I wasn't sure. It would be preferable if this was merged to |
@ryanstewart I agree with @busykai that we should be merging this with @dvorapa Could you please re-target this to |
@dvorapa Don't bother re-targeting this to |
Switch "Brackets" to "{APP_NAME}" in strings
I can not manage to re-target that. It looks like my |
@dvorapa Fwiw, the reason we didn't use |
Please switch these in root strings