Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Switch "Brackets" to "{APP_NAME}" in strings #10934

Merged
merged 1 commit into from
Apr 20, 2015
Merged

Switch "Brackets" to "{APP_NAME}" in strings #10934

merged 1 commit into from
Apr 20, 2015

Conversation

dvorapa
Copy link
Contributor

@dvorapa dvorapa commented Apr 18, 2015

Please switch these in root strings

@busykai
Copy link
Contributor

busykai commented Apr 20, 2015

Nice catch! Thank you! This looks good! I'm not merging this only because I'm not sure where in the release cycle we are.

@ryanstewart
Copy link
Contributor

Agreed, great catch @dvorapa. I think we're all set to merge this since it's a pull request against the release branch. The only thing I'm not sure about is the impact on translations. Once we get the final translations we should do a scrub to make sure we're using {APP_NAME} there as well.

@nethip do you know what the best way to handle this is?

@busykai
Copy link
Contributor

busykai commented Apr 20, 2015

@ryanstewart, @nethip :

The only thing I'm not sure about is the impact on translations. Once we get the final translations we
should do a scrub to make sure we're using {APP_NAME} there as well.

This is why I wasn't sure. It would be preferable if this was merged to master and then re-translate for the next release... It may make it a little difficult to catch (for the translator) if it was merged to the release branch since normally root strings are frozen when release is cut. Or may be I'm over complicating the logistics...

@nethip
Copy link
Contributor

nethip commented Apr 20, 2015

@ryanstewart I agree with @busykai that we should be merging this with master and have the translations happen there. That way, we would not be effected with the string translations for this release, as we are put in a string freeze on release branch.

@dvorapa Could you please re-target this to master. And thanks for catching this 😄

@nethip
Copy link
Contributor

nethip commented Apr 20, 2015

@dvorapa Don't bother re-targeting this to master. I am merging this I had a word with LOC team and they are going to send the strings for translations after merging this.

nethip added a commit that referenced this pull request Apr 20, 2015
Switch "Brackets" to "{APP_NAME}" in strings
@nethip nethip merged commit 4ebdd1a into adobe:release Apr 20, 2015
@dvorapa
Copy link
Contributor Author

dvorapa commented Apr 23, 2015

I can not manage to re-target that. It looks like my patch-2 branch is more than 5 commits ahead from Brackets' master (forked from the release branch after first commits with german translation were merged). And I don't want to make a mess in Brackets commit history. Nevertheless, I tried to re-target it in #10991. Feel free to close #10991 because of any merging issue appeared.

@dvorapa dvorapa deleted the patch-2 branch April 27, 2015 12:53
@peterflynn
Copy link
Member

@dvorapa Fwiw, the reason we didn't use {APP_NAME} originally was because it seemed unlikely strings about sending data to an Adobe server would apply to anyone else's spinoff apps -- so forks with their own distribution will probably need to replace these strings anyway.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants