Fix for #12970: Non-default languages and user preferences bug #12979
Conversation
|
@zaggino i'll try and i'll let you know |
|
@zaggino Just tested it again on Windows & Ubuntu with the latest master and it works fine with the steps described in the issue. I may have missed something so I'll take another look later |
This reverts commit c2b2387.
Better way of dealing with this bug is just to remove invalid mappings from the prefs state, and force an _updateToPrefs call when defining a non-default language
|
Reset the branch, I think I messed up my fork somehow. Should work fine now. |
Check if a language isn't in the file extension map when it should be
|
I was able to produce a fix for the steps in the issue but I didn't try using .twig files (issue describes step 2 as any file type that's not supported). I can now see that overriding .twig is a specific scenario that doesn't work, but all other extensions are fine. So I've added a fix for this as well. You can now override Apologies for any spam. |
|
Thx for your work, i don't have the bug anymore |
|
@haslam22 let me know when you think it's ready, I see you're still adding some commits. |
|
@zaggino All finished now, thanks for taking the time to review. |
|
reviewed & merged, thanks @haslam22 ! |
|
Nice job @haslam22 👍 |
This fixes #12970 by removing invalid mappings from the preference state, occurring when a language has not been loaded yet. When the language is eventually loaded, an
_updateFromPrefscall restores the preferences.