Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Bug: 12766 - Now language mode can be changed for unsaved Untitled Do… #13086

Merged
merged 1 commit into from
Feb 16, 2017
Merged

Bug: 12766 - Now language mode can be changed for unsaved Untitled Do… #13086

merged 1 commit into from
Feb 16, 2017

Conversation

saurabh95
Copy link
Contributor

@saurabh95 saurabh95 commented Feb 8, 2017 •
edited
Loading

Bug: #12766 - Now language mode can be changed for unsaved Untitled Documents

@saurabh95 saurabh95 added this to the Release 1.9 milestone Feb 8, 2017
petetnt
petetnt reviewed Feb 9, 2017
View reviewed changes
Copy link
Collaborator

@petetnt petetnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codewise LGTM, haven't had time to test this yet

@ficristo
Copy link
Collaborator

I believe this fixes part of #11637 but not #12766.
If you already didn't you should take a look to the corresponding trello card:
https://trello.com/c/CNXuU4TY/1369-switch-language-type-of-untitled-documents

I defer review to @petetnt and @swmitra on this one.

@ficristo ficristo removed their request for review February 10, 2017 10:31
swmitra
swmitra approved these changes Feb 15, 2017
View reviewed changes
Copy link
Collaborator

@swmitra swmitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@swmitra
Copy link
Collaborator

swmitra commented Feb 15, 2017

@petetnt Once you approve, I will merge this PR 😄

@swmitra
Copy link
Collaborator

swmitra commented Feb 16, 2017

Merging this PR.
@petetnt do let us know if you discover any issues with this.
I haven't found any issues after using this branch for a couple of days.

@swmitra swmitra merged commit 7883b01 into master Feb 16, 2017
@petetnt petetnt deleted the saurabh95/UntitledModeChangeEnabled branch February 16, 2017 12:14
@saurabh95 saurabh95 restored the saurabh95/UntitledModeChangeEnabled branch March 21, 2017 03:46
@saurabh95 saurabh95 deleted the saurabh95/UntitledModeChangeEnabled branch April 9, 2017 07:08
@grafluxe
Copy link

Thanks for adding this feature, as it is very useful. I found a bug and reported here: 13381.

@swmitra

@grafluxe grafluxe mentioned this pull request May 25, 2017
Open
3 tasks
This was referenced Aug 30, 2021
Open
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@petetnt petetnt petetnt left review comments

@swmitra swmitra swmitra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 1.9
Development

Successfully merging this pull request may close these issues.
5 participants
@saurabh95 @ficristo @swmitra @grafluxe @petetnt