Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Rename LoadEvents to AppIinit #1464

Merged
merged 4 commits into from
Aug 28, 2012
Merged

Rename LoadEvents to AppIinit #1464

merged 4 commits into from
Aug 28, 2012

Conversation

jasonsanjose
Copy link
Member

Fix for #1404

  • Rename LoadEvents to AppInit
  • Rename ready to appReady
  • Rename htmlContentLoadComplete to htmlReady

Wiki pages have been updated as well: https://github.com/adobe/brackets/wiki/Brackets-Development-How-Tos and https://github.com/adobe/brackets/wiki/Release-notes:-Sprint-13

@ghost ghost assigned gruehle Aug 27, 2012
@gruehle
Copy link
Member

gruehle commented Aug 27, 2012

Reviewing

* This module dispatches these events:
* - htmlContentLoadComplete - When the main application template is rendered
* This module defines 2 methods for client modules to attach callbacks:
* - htmlReady - When the main application template is rendered
* - ready - When Brackets completes loading all modules and extensions
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment should say appReady

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@gruehle
Copy link
Member

gruehle commented Aug 28, 2012

Initial review complete.

@jasonsanjose
Copy link
Member Author

Fixes pushed

@gruehle
Copy link
Member

gruehle commented Aug 28, 2012

Looks good! Merging.

gruehle added a commit that referenced this pull request Aug 28, 2012
@gruehle gruehle merged commit a2d2e68 into master Aug 28, 2012
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants