This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Chris/issue 18 #431
Merged
Chris/issue 18 #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reviewing |
| function updateChildWidthToParentScrollwidth($parent) { | ||
| var $firstChild = $parent.children().first(); | ||
| //clear the width first so we get the natural scrollWidth below | ||
| $firstChild.width(""); |
There was a problem hiding this comment.
This function should either work on all children of the parent, or be passed a child (if you just pass a child, you will need to do an initial pass to clear the child widths first).
There was a problem hiding this comment.
I'll do it to all the children
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #18. The man thing was adjusting the child width to the parents scrollWidth