…dule.

Simplifies QuickOpen code, removing workarounds and allowing it to use the
ModalBar autoClose option. Fixes bugs with arrow key handling, cleans up
APIs, and more consistently highlights the item that pressing Enter will
select.

…search-field

Conflicts:
	src/search/QuickOpen.js
	src/styles/brackets.less
	src/widgets/ModalBar.js

…ewline

in editor (new, cmv4-only issue)
- Fix bug: clicking Ctrl+T item without typing any text didn't work
- Fix bug: pressing Enter to finish Goto Line didn't set cursor pos
- Clean up docs, remove some TODOs
- Remove unused keyup listener code (jQuery was silently no-oping when
asked to attach a null event handler)
- Simplify "@" detection in the three core Ctrl+T providers

…rchField.

Remove logging code and old TODOs. Round out documentation.

Fix bug where pressing enter in Goto Line mode did nothing if a previous
search mode had been used earlier (currentPlugin was stale).

…search-field

Revert PR #7316 - no longer needed to fix #7307.
Tweak the PR #7358 fix to cut down the delay before the dropdown appears to
the bare minimum.

…search-field

Reimplements the fixes from PR #9624 & #9153 in a simpler way: instead of
trying to selectively suppress ModalBar's scroll pos adjustments, in cases
where we need to revert scroll pos in one file, just wait until ModalBar is
done adjusting scroll pos and *then* reset the one we care about. Made
possible by the fact that we now listen for ModalBar's "close" event and
the event passes info on the reason for closing.

Removes delay before results list opens: in CEF 2171 it seems both unneeded
(animation is smooth without it) and it triggers an apparent Chrome bug where
the post-animation state is displayed during the delay period even though
the computed style reflects the pre-animation state.

Conflicts:
    src/search/QuickOpen.js
    src/styles/brackets.less
    src/styles/brackets_colors.less
    src/widgets/ModalBar.js

- Fix bug where arrow keys with bare "@" didn't scroll to item in editor
(with unit test)
- Fix code style nits & update docs. Reponding to code review only one
year late :-)
- Fix JSHint nits about unused vars
- CSS tweak when last item in list highlighted