Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add two functions about copy and paste #494

Merged
merged 5 commits into from
Oct 10, 2022
Merged

feat: add two functions about copy and paste #494

merged 5 commits into from
Oct 10, 2022

Conversation

kaylezhangzhaoLin
Copy link
Contributor 

1. copy from selenoid clipboard to local
2. paste to selenoid from local clipboard

@kaylezhangzhaoLin
feat: add two functions
baf1aad 
    1. copy from selenoid clipboard to local
    2. paste to selenoid from local clipboard
@kaylezhangzhaoLin kaylezhangzhaoLin changed the title feat: add two functions feat: add two functions about copy and paste Sep 30, 2022
@vania-pooh
Copy link
Member

@carl-pki could you please provide a screenshot how it looks like?

@codecov
Copy link

codecov bot commented Sep 30, 2022 •
edited
Loading

Codecov Report

Base: 31.42% // Head: 30.71% // Decreases project coverage by -0.70% ⚠️

Coverage data is based on head (462bdd3) compared to base (1d2800d).
Patch coverage: 4.16% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #494      +/-   ##
==========================================
- Coverage   31.42%   30.71%   -0.71%     
==========================================
  Files          38       38              
  Lines         732      752      +20     
  Branches      131      137       +6     
==========================================
+ Hits          230      231       +1     
- Misses        441      458      +17     
- Partials       61       63       +2
Flag Coverage Δ
go 30.71% <4.16%> (-0.71%) ⬇️
ui 22.59% <4.16%> (-0.62%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ui/src/components/VncCard/index.js 0.00% <0.00%> (ø)
ui/src/setupProxy.js 0.00% <0.00%> (ø)
ui/src/components/VncCard/style.css.js 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kaylezhangzhaoLin
Copy link
Contributor Author

pleas tell me If you need any more information

@vania-pooh
Copy link
Member

@carl-pki please attach a screenshot :)

@kaylezhangzhaoLin
feat: add two functions
0bb5809 
    1. copy from selenoid clipboard to local
    2. paste to selenoid from local clipboard
@kaylezhangzhaoLin
Copy link
Contributor Author

217f0efaa3606be5e0fe5c688075ebf
0916567cab78d7b14fc42785773025b

@kaylezhangzhaoLin
Copy link
Contributor Author

kaylezhangzhaoLin commented Oct 9, 2022 •
edited
Loading

I do not know how get service address, So I just support same address as Selenoid-UI and port must is 4444, If you have any suggestion please write down below. Thank you.

@kaylezhangzhaoLin
feat: add two functions
c875939 
    1. copy from selenoid clipboard to local
    2. paste to selenoid from local clipboard
@kaylezhangzhaoLin
feat: add two functions
282f1a2 
    1. copy from selenoid clipboard to local
    2. paste to selenoid from local clipboard
@vania-pooh
Copy link
Member

@carl-pki is it possible to move these two buttons to the right and change color e.g. to pale yellow?

@kaylezhangzhaoLin
feat: add two functions
462bdd3 
    1. copy from selenoid clipboard to local
    2. paste to selenoid from local clipboard
@kaylezhangzhaoLin
Copy link
Contributor Author

what do you think ?
image

@vania-pooh
Copy link
Member

@carl-pki looks good for me. Let's wait for @lanwen to review the code itself.

lanwen
lanwen approved these changes Oct 10, 2022
View reviewed changes
Copy link
Collaborator

@lanwen lanwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good!

@lanwen lanwen merged commit be94f72 into aerokube:master Oct 10, 2022
@vania-pooh
Copy link
Member

@carl-pki thank you for contribution!

@kaylezhangzhaoLin
Copy link
Contributor Author

kaylezhangzhaoLin commented Oct 13, 2022 via email

@kaylezhangzhaoLin
Copy link
Contributor Author

kaylezhangzhaoLin commented Oct 14, 2022 via email

@vania-pooh
Copy link
Member

@carl-pki done. Rebuilt 1.10.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lanwen lanwen lanwen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kaylezhangzhaoLin @vania-pooh @lanwen