Feedback index #136
Merged
Feedback index #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also removes the `index?` specifications because it's kind of unnecessary to have and I didn't want to account for it in the test updates
toyhammered
requested changes
Jul 2, 2023
| edit_feedback_path(feedback), | ||
| class: "btn btn-sm capitalize #{variant} #{classes}" | ||
| ) do | ||
| content || 'Edit' |
There was a problem hiding this comment.
where does thecontent come from?
There was a problem hiding this comment.
It's a ViewComponent thing. It comes from a block that's passed to the component. This is a way for the button to have different kinds of text. So if I wanted the button to say "Edit Feedback" instead of just edit ->
<%= render Feedback::EditButtonComponent(**args) do %>
Edit Feedback
<% end %>The content will be "Edit Feedback" and that's what will get rendered. With no block passed, content is nil, so I have it default to "Edit".
Could also in the future pass an icon in through this or some markup that would be nested in the button.
There was a problem hiding this comment.
gotcha! That is really cool!
Done to distinguish between ruby "classes" and HTML classes
toyhammered
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes #125
Description
show?policy to not authorize draft feedback for receiversFeedback::EditButtonComponentto allow it to fit more usecases.Feedback::ItemComponentto represent an individual feedback "item" in the list of feedback on a user's index pagefeedbacks#indexScreenshots
Mobile
Desktop