add in check in cta component #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
toyhammered
approved these changes
Jul 10, 2023
| @@ -7,6 +7,10 @@ def index | |||
| @standup_meetings = @standup_meeting_group.standup_meetings | |||
| .includes(:user) | |||
| .where(meeting_date: @meeting_date) | |||
| @current_user_standup_meeting = @standup_meetings.find do |meeting| | |||
There was a problem hiding this comment.
small nit, can you use detect. Unsure if this is defined in our rubocop rules but find/where etc I associate with ActiveRecord while detect and select are arrays.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds in the check in cta component. This CTA is meant to be a reasuable that directs user to check in if they haven't, edit their response if they have submitted a startup meeting, and edit their response if they skipped their startup meeting.
One caveat here -- this PR does not handle the empty state wherein an there is no standup meeting defined for the date in question. To enable this functionality would require handling how the
StandupMeeting::SkipsControllerandStandupMeeting::CompletionsControllerdeal with unpersistedStandupMeetings, as currently rendering this component depends onStandupMeeting::ActionButtonComponent, which expects that the standup meeting passed to it is persisted.Screen shots: