Feedback edit #149
Merged
Feedback edit #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Certain pages need this because the turbo frame wouldn't make for a good user experience.
JoshDevHub
commented
Jul 9, 2023
| <p class="p-4">Awaiting completion of feedback.</p> | ||
| <% end %> | ||
| </div> | ||
| <%= tag.turbo_frame(id: dom_id(feedback)) do %> |
There was a problem hiding this comment.
Have to use this instead of the turbo_frame_tag helper because of some compatibility issues with ViewComponent. See this documentation
toyhammered
approved these changes
Jul 9, 2023
afogel
reviewed
Jul 10, 2023
| <%= tag.turbo_frame(id: dom_id(feedback)) do %> | ||
| <div class="flex justify-between items-center"> | ||
| <%= heading(class: "text-lg") %> | ||
| <%= render Feedback::EditButtonComponent.new(feedback:, current_user: user) %> |
There was a problem hiding this comment.
I know this is merged, but out of curiousity, what is the difference between using the user var passed to the container component and current_user? Would it be more descriptive to rename user to current_user?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Feedback::ContainerComponentsuch that it can be replaced by the edit view (and vice versa)dataparams for theFeedback::EditButtonComponentso that turbo can be disabled depending on the situationScreenshots
Desktop for Full Page Edit
Desktop for Edit Turbo Frame
Mobile for Full Page Edit
Mobile for Edit Turbo Frame
Issue
Closes #140