-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot recognize provider.iam
as an object given an arn for iam role
#350
Comments
Thanks for the report @lhyleo! Seems like a simple issue to fix. I might get a chance to look at it over the next week |
@NoxHarmonium When users are specifying ARNs, they are responsible to add the necessary permissions on their own. I think |
Good point. Sorry I'm taking so long to get around to this. Things are bit hectic. I'll try and have a look this weekend. |
@NoxHarmonium Tested with an actual deployment, I found the following change is also required in my case. It's also trivial but it's your call if it should be split into another PR. When |
Fixes #350 - Instead of getting serverless to generate a role for the lambdas, you can create one yourself and specify the ARN in the serverless config - In this case, serverless-sns-sqs-lambda should just skip process that adds policies to the lambda role
@NoxHarmonium LGTM. Tested the branch with an actual deployment and it works. I am having some runtime errors about evanw/esbuild#495 but I don't think it's related, I'd say this is good to go. |
🎉 This issue has been resolved in version 0.9.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Thanks for your help @vicary ! |
When adding an iam role to the serverless.yml, it can only be done in this way
However, the best practice for setting the iam role should be setting the role as an object (with the warning from serverless
Configuration warning at 'provider.iam': should be object
)But this will throw an error
The text was updated successfully, but these errors were encountered: