Remove usage of JobStorage.Current #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: this pull request will be really useful when HangfireIO/Hangfire#2146 will also be merged. |
|
Got it, ping me when it's ready |
0xced
force-pushed
the
IBackgroundJobClientV2
branch
from
b51eb1e
to
2cddd5c
Compare
When using the ASP.NET Core Hangfire integration, i.e. `services.AddHangfire(...)` the `JobStorage.Current` static property may never be assigned through the application lifetime as it's injected. We can get rid of `JobStorage.Current` and access the storage from either the new `IBackgroundJobClientV2` interface introduced in Hangfire 1.8 (Atom + Trigger classes) or through the `ApplyStateContext` (AtomDeletedStateElectionFilter class).
Possible since HangfireIO/Hangfire@1ae167e
0xced
force-pushed
the
IBackgroundJobClientV2
branch
from
2cddd5c
to
f1024d3
Compare
|
Now that Hangfire 1.8 is released it might be worth considering. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the ASP.NET Core Hangfire integration, i.e.
services.AddHangfire(...)theJobStorage.Currentstatic property may never be assigned through the application lifetime as it's injected.We can get rid of
JobStorage.Currentand access the storage from either the newIBackgroundJobClientV2interface introduced in Hangfire 1.8 (Atom + Trigger classes) or through theApplyStateContext(AtomDeletedStateElectionFilter class).Note that I have opened this pull request as a draft since it depends on Hangfire 1.8.0-rc2 which is not yet the final 1.8 version.