Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples and docs updated #1331

Merged
merged 2 commits into from
Sep 4, 2024
Merged

Examples and docs updated #1331

merged 2 commits into from
Sep 4, 2024

Conversation

nicl-nno
Copy link
Collaborator

@nicl-nno nicl-nno commented Sep 4, 2024

  • cases moved to examples
  • minor docs updates

Motivation: request by reviewer

Copy link
Contributor

github-actions bot commented Sep 4, 2024

All PEP8 errors has been fixed, thanks ❤️

Comment last updated at

@nicl-nno nicl-nno requested a review from DRMPN September 4, 2024 13:07
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.12%. Comparing base (92218df) to head (f6c39ce).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1331      +/-   ##
==========================================
- Coverage   80.14%   80.12%   -0.02%     
==========================================
  Files         146      146              
  Lines       10285    10285              
==========================================
- Hits         8243     8241       -2     
- Misses       2042     2044       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@DRMPN DRMPN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

У нас же нет автоматического запуска примеров? Может запустить 1-2 чтобы проверить?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Мне прошлые импорты больше нравятся, конечно. Однако по pep8 это более правильные.

@nicl-nno nicl-nno merged commit 3998d22 into master Sep 4, 2024
10 checks passed
@nicl-nno nicl-nno deleted the move-cases branch September 4, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants