Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: close connection on error #358

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pedrokiefer
Copy link

Port the solution from PyMySQL: PyMySQL/PyMySQL#540

Might solve #340.

@codecov
Copy link

codecov bot commented Nov 20, 2018

Codecov Report

Merging #358 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #358   +/-   ##
=======================================
  Coverage   93.17%   93.17%           
=======================================
  Files           9        9           
  Lines        1129     1129           
  Branches      161      161           
=======================================
  Hits         1052     1052           
  Misses         54       54           
  Partials       23       23           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 298d2f1...51d83d4. Read the comment docs.

@terricain
Copy link
Collaborator

Any clue why the tests failed for py3.5.3?

@terricain
Copy link
Collaborator

Other than that the tests and port looks good. Have you tested it normally by having it connected to a maria db, restarting it and seeing if the close packets are now understood?

@pedrokiefer
Copy link
Author

Really odd that it failed with python 3.5.3, i'll look into it.

I have not yet tested this against mariadb, i'll do a simple script to replicate the scenario and test it tomorrow.

@goDeni
Copy link

goDeni commented Aug 19, 2020

Please merge this

@CLAassistant
Copy link

CLAassistant commented Nov 16, 2020

CLA assistant check
All committers have signed the CLA.

@Nothing4You
Copy link
Collaborator

thanks for the PR, I intend to patch the original issue in #660.
I'm keeping this open to review the tests later on.

@pedrokiefer
Copy link
Author

Thanks for fixing this issue!

@Nothing4You
Copy link
Collaborator

i'll keep this open for now until i've had time to review and probably merge the tests

@Nothing4You Nothing4You reopened this Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants