-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: close connection on error #358
base: master
Are you sure you want to change the base?
refactor: close connection on error #358
Conversation
Codecov Report
@@ Coverage Diff @@
## master #358 +/- ##
=======================================
Coverage 93.17% 93.17%
=======================================
Files 9 9
Lines 1129 1129
Branches 161 161
=======================================
Hits 1052 1052
Misses 54 54
Partials 23 23 Continue to review full report at Codecov.
|
Any clue why the tests failed for py3.5.3? |
Other than that the tests and port looks good. Have you tested it normally by having it connected to a maria db, restarting it and seeing if the close packets are now understood? |
Really odd that it failed with python 3.5.3, i'll look into it. I have not yet tested this against mariadb, i'll do a simple script to replicate the scenario and test it tomorrow. |
Please merge this |
thanks for the PR, I intend to patch the original issue in #660. |
Thanks for fixing this issue! |
i'll keep this open for now until i've had time to review and probably merge the tests |
Port the solution from PyMySQL: PyMySQL/PyMySQL#540
Might solve #340.