Fix aiomysql.sa in Python 3.7 and run tests for python 3.7 in CI #434

zhoukuncheng · 2019-09-08T04:34:01Z

What do these changes do?

Fix async iterator protocol in aiomysql.utils._SAConnectionContextManager,
and run tests for python 3.7 in CI.

Add __aiter__ and __anext__ methods for _SAConnectionContextManager
Update .travis.yml for Python 3.7

Are there changes in behavior for the user?

No changes.

Related issue number

#410

Checklist

I think the code is well written
Unit tests for the changes exist
Documentation reflects the changes
Add a new news fragment into the CHANGES folder
- name it <issue_id>.<type> (e.g. 588.bugfix)
- if you don't have an issue_id change it to the pr id after creating the PR
- ensure type is one of the following:
  - .feature: Signifying a new feature.
  - .bugfix: Signifying a bug fix.
  - .doc: Signifying a documentation improvement.
  - .removal: Signifying a deprecation or removal of public API.
  - .misc: A ticket has been closed, but it is not of interest to users.
- Make sure to use full sentences with correct case and punctuation, for example: Fix issue with non-ascii contents in doctest text files.

codecov · 2019-09-08T04:38:54Z

Codecov Report

Merging #434 into master will increase coverage by 0.05%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #434      +/-   ##
==========================================
+ Coverage   92.28%   92.34%   +0.05%     
==========================================
  Files           9        9              
  Lines        1180     1188       +8     
  Branches      172      173       +1     
==========================================
+ Hits         1089     1097       +8     
  Misses         64       64              
  Partials       27       27

Impacted Files	Coverage Δ
aiomysql/utils.py	`90% <100%> (+0.86%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2f8a6d...77f6b95. Read the comment docs.

zhoukuncheng · 2019-09-09T16:03:25Z

@terrycain I need someone to review this PR.
It will be nice to see a new release built and published to PyPI after this PR merged.

.travis.yml

aiomysql/utils.py

tests/conftest.py

tests/test_issues.py

.travis.yml

…ager

codecov-io · 2019-09-12T16:59:08Z

Codecov Report

Merging #434 into master will increase coverage by 0.05%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #434      +/-   ##
==========================================
+ Coverage   92.28%   92.34%   +0.05%     
==========================================
  Files           9        9              
  Lines        1180     1188       +8     
  Branches      172      173       +1     
==========================================
+ Hits         1089     1097       +8     
  Misses         64       64              
  Partials       27       27

Impacted Files	Coverage Δ
aiomysql/utils.py	`90% <100%> (+0.86%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b16e5bd...da130a5. Read the comment docs.

codecov-io · 2019-09-12T16:59:09Z

Codecov Report

Merging #434 into master will increase coverage by 0.05%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #434      +/-   ##
==========================================
+ Coverage   92.28%   92.34%   +0.05%     
==========================================
  Files           9        9              
  Lines        1180     1188       +8     
  Branches      172      173       +1     
==========================================
+ Hits         1089     1097       +8     
  Misses         64       64              
  Partials       27       27

Impacted Files	Coverage Δ
aiomysql/utils.py	`90% <100%> (+0.86%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2f8a6d...0434fe1. Read the comment docs.

.travis.yml

webknjaz · 2019-09-12T19:20:15Z

.travis.yml

          env: PYTHONASYNCIODEBUG=
          addons:
              mysql: 5.7


 before_script:
+    - "sudo systemctl start mysql || true"


Add a global addons section instead.

Updated, add - mysql in global services section ,
Setting up Databases and Services - Travis CI

ethe · 2020-02-20T17:38:43Z

Anything updates?

webknjaz · 2020-04-24T13:59:14Z

@CeresCa?

terricain · 2020-04-25T13:02:59Z

Am busy with a new job but this projects been left for a while. Will have a look this coming week once ive fixed travis

terricain · 2020-04-25T21:56:07Z

Remove the stuff from .travis matrix except from changing the main python version 3.6 to 3.7

nickpro · 2020-05-25T11:07:12Z

does this PR abandoned?

Nothing4You · 2022-01-30T06:54:07Z

thank you for the PR.

python 3.7 support has been implemented quite a while ago, therefore this is no longer relevant.

Nothing4You · 2022-01-30T07:00:24Z

for the SA fix, this should be covered in #494, which also includes a test case.

webknjaz requested changes Sep 9, 2019

View reviewed changes

.travis.yml Outdated Show resolved Hide resolved

.travis.yml Outdated Show resolved Hide resolved

aiomysql/utils.py Outdated Show resolved Hide resolved

tests/conftest.py Outdated Show resolved Hide resolved

tests/test_issues.py Outdated Show resolved Hide resolved

webknjaz reviewed Sep 10, 2019

View reviewed changes

.travis.yml Outdated Show resolved Hide resolved

Fix async iterator protocol in aiomysql.utils._SAConnectionContextMan…

b0da2dd

…ager

webknjaz reviewed Sep 12, 2019

View reviewed changes

.travis.yml Outdated Show resolved Hide resolved

webknjaz reviewed Sep 12, 2019

View reviewed changes

.travis.yml Show resolved Hide resolved

webknjaz reviewed Sep 12, 2019

View reviewed changes

Add Python 3.7 in matrix

0434fe1

webknjaz approved these changes Sep 14, 2019

View reviewed changes

nickpro approved these changes May 25, 2020

View reviewed changes

sloev mentioned this pull request Jun 8, 2020

The next release plan? #466

Closed

willbuckner approved these changes Dec 6, 2020

View reviewed changes

aio-libs deleted a comment from CLAassistant Jan 30, 2022

Nothing4You closed this Jan 30, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix aiomysql.sa in Python 3.7 and run tests for python 3.7 in CI #434

Fix aiomysql.sa in Python 3.7 and run tests for python 3.7 in CI #434

zhoukuncheng commented Sep 8, 2019 •

edited

Loading

codecov bot commented Sep 8, 2019 •

edited

Loading

zhoukuncheng commented Sep 9, 2019

codecov-io commented Sep 12, 2019

codecov-io commented Sep 12, 2019 •

edited by codecov bot

Loading

webknjaz Sep 12, 2019

zhoukuncheng Sep 13, 2019

ethe commented Feb 20, 2020

webknjaz commented Apr 24, 2020

terricain commented Apr 25, 2020

terricain commented Apr 25, 2020

nickpro commented May 25, 2020

Nothing4You commented Jan 30, 2022

Nothing4You commented Jan 30, 2022

Fix aiomysql.sa in Python 3.7 and run tests for python 3.7 in CI #434

Fix aiomysql.sa in Python 3.7 and run tests for python 3.7 in CI #434

Conversation

zhoukuncheng commented Sep 8, 2019 • edited Loading

What do these changes do?

Are there changes in behavior for the user?

Related issue number

Checklist

codecov bot commented Sep 8, 2019 • edited Loading

Codecov Report

zhoukuncheng commented Sep 9, 2019

codecov-io commented Sep 12, 2019

Codecov Report

codecov-io commented Sep 12, 2019 • edited by codecov bot Loading

Codecov Report

webknjaz Sep 12, 2019

Choose a reason for hiding this comment

zhoukuncheng Sep 13, 2019

Choose a reason for hiding this comment

ethe commented Feb 20, 2020

webknjaz commented Apr 24, 2020

terricain commented Apr 25, 2020

terricain commented Apr 25, 2020

nickpro commented May 25, 2020

Nothing4You commented Jan 30, 2022

Nothing4You commented Jan 30, 2022

zhoukuncheng commented Sep 8, 2019 •

edited

Loading

codecov bot commented Sep 8, 2019 •

edited

Loading

codecov-io commented Sep 12, 2019 •

edited by codecov bot

Loading