Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

airtasker#1367 Implementation for SchemaProps #1376

Merged
merged 13 commits into from
May 3, 2021
Merged

airtasker#1367 Implementation for SchemaProps #1376

merged 13 commits into from
May 3, 2021

Conversation

Thodin3
Copy link
Contributor

@Thodin3 Thodin3 commented Apr 21, 2021

Description, Motivation and Context

Please see #1367
The OASv3 has some properties for types :
minLength, maxLength, pattern, minimum, maximum, default, ...
It's possible to implement it in comments in the contract parameters.

Checklist:

  • I've added/updated tests to cover my changes
  • I've created an issue associated with this PR

@lfportal lfportal self-requested a review April 21, 2021 11:51
lfportal
lfportal reviewed Apr 27, 2021
View reviewed changes
Copy link
Contributor

@lfportal lfportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Thodin3, just a couple of comments.

lib/src/types.ts Outdated Show resolved Hide resolved
lib/src/definitions.ts Outdated Show resolved Hide resolved
lib/src/generators/openapi3/__spec-examples__/contract-with-schemaprops.ts Outdated Show resolved Hide resolved
lib/src/generators/openapi3/__spec-examples__/contract-with-schemaprops.ts Outdated Show resolved Hide resolved
@Thodin3 Thodin3 marked this pull request as draft April 28, 2021 10:52
lfportal
lfportal reviewed Apr 28, 2021
View reviewed changes
lib/src/types.ts Outdated Show resolved Hide resolved
lib/src/types.ts Outdated Show resolved Hide resolved
@Thodin3 Thodin3 requested a review from lfportal April 29, 2021 16:53
@Thodin3 Thodin3 marked this pull request as ready for review April 29, 2021 16:54
@Thodin3 Thodin3 requested a review from lfportal May 3, 2021 09:10
@lfportal lfportal merged commit b0c6351 into airtasker:master May 3, 2021
@lfportal lfportal linked an issue May 3, 2021 that may be closed by this pull request
Implement the OASv3 schema properties for types #1367
Closed
@Thodin3
Copy link
Contributor Author

Thodin3 commented May 3, 2021 •
edited
Loading

Hello @lfportal,
Thanks.
I can see that the CI-Test is failing on master now.
This is because of the new feature: property.with.dots

Possible fix is:
add schemaProps: undefined in type: {kind: TypeKind.STRING} in lib/src/parsers/query-params-parser.spec.ts:128

Thodin3 added a commit to Thodin3/spot that referenced this pull request May 4, 2021
@Thodin3
airtasker#1367 Implementation for SchemaProps (airtasker#1376)
82bc169
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lfportal lfportal lfportal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement the OASv3 schema properties for types
2 participants
@Thodin3 @lfportal