Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

airtasker#1417 @oaSchemaProp example fails with numerical strings, Date, DateTime, Object, Array, Union or Intersection #1419

Merged
merged 5 commits into from
May 11, 2021

Conversation

Thodin3
Copy link
Contributor

@Thodin3 Thodin3 commented May 11, 2021

Description, Motivation and Context

Please see #1417
When using @oaSchemaProp example, providing a numerical string like "123.3" for a String type fails.
When using @oaSchemaProp example for Date, DateTime, Object, Array, Union or Intersection type it fails.

Fix in this PR :
in function extractJSDocSchemaProps(
const typeOf is refactored and will use the JSON.parse real type instead of regexp filtering.

Checklist:

  • I've added/updated tests to cover my changes
  • I've created an issue associated with this PR

@lfportal lfportal linked an issue May 11, 2021 that may be closed by this pull request
@lfportal lfportal self-requested a review May 11, 2021 22:27
Copy link
Contributor

@lfportal lfportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @Thodin3

@lfportal lfportal merged commit b87a8bd into airtasker:master May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@oaSchemaProp example fails with numerical strings
2 participants