Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PSC-2029] Add lint rule to prevent trailing forward slashes #2154

Merged
merged 3 commits into from
Nov 20, 2023
Merged

[PSC-2029] Add lint rule to prevent trailing forward slashes #2154

merged 3 commits into from
Nov 20, 2023

Commits on Nov 17, 2023

  1. [PSC-2029] Add lint rule to prevent trailing forward slashes 

    In an attempt to increase consistency across endpoints, Airtasker wants
to avoid having endpoints whose path ends with a trailing forward slash.
This PR adds a lint rule that rejects contracts containing endpoints
with a trailing forward slash.

To maintain backwards compatibility, the default `LintConfig` has been
updated to only `warn` on such issues.

The rule can be enforced by running
`spot lint <api.rs> --no-trailing-forward-slash=error`

The rule can be fully disabled by running
`spot lint <api.ts> --no-trailing-forward-slash=off`.
    @flavray
    flavray committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    748d25e View commit details
    Browse the repository at this point in the history

  2. Update function docstring

    @flavray
    flavray committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    e664cac View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2023

  1. Merge branch 'master' into PSC-2029-no-trailing-forward-slash

    @flavray
    flavray authored Nov 19, 2023
    Configuration menu
    Copy the full SHA
    b444b10 View commit details
    Browse the repository at this point in the history