-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed the ScatterGatherFirstCompleted router logic #1769
Fixed the ScatterGatherFirstCompleted router logic #1769
Conversation
@@ -78,14 +79,18 @@ public ScatterGatherFirstCompletedRoutees(Routee[] routees, TimeSpan within) | |||
/// <param name="sender">The actor sending the message.</param> | |||
public override void Send(object message, IActorRef sender) | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit iffy on the error handling here. What happens if one of these tasks throws?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed this by using task completion sources and Status.Failure messages
@annymsMthd looks like there are public API changes in here - you'll need to follow this: http://getakka.net/docs/akka-developers/public-api-changes |
I have a few upgrades im doing for this |
var res = routedActor.Ask<int>(new Broadcast(0), TimeSpan.FromSeconds(10)); | ||
res.Wait(); | ||
res.Result.ShouldBe(14); | ||
public DelayStopActor(int id, TimeSpan waitTime) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prob don't need this. I saw that the other actor delays based on id so i can just use that functionality
…router-logic Fixed the ScatterGatherFirstCompleted router logic
Fixes #1718 The spec was using broadcast which never goes through the specific router routee logic