Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix xunit warnings #3636

Merged
merged 8 commits into from
Oct 29, 2018
Merged

Conversation

sean-gilliam
Copy link
Member

This PR fixes a number of issues caught by the xunit analyzer.

  • xunit1013 - these were false positives due to how we run the MNTK tests
  • xunit1014 - basically changing hardcoded string references to nameof
  • xunit2000 - basically changing the order so that expected value is first
  • xunit2003 - use the xunit Null() check instead of Equals()
  • xunit2004 - use the xunit True()/False() check instead of Equal()
  • xunit2009 - use the xunit Contains()/StartsWith() check instead of Equals() + string methods
  • xunit2012 - use the xunit Contains() check instead of Equals() + Any()

Anecdotal data, but I was able to shave off a minute from the build time and the build log was a bit nicer to look at.

@Aaronontheweb
Copy link
Member

nice work @sean-gilliam

@Aaronontheweb Aaronontheweb merged commit 53a764a into akkadotnet:dev Oct 29, 2018
@Aaronontheweb Aaronontheweb added this to the 1.3.10 milestone Oct 29, 2018
@sean-gilliam sean-gilliam deleted the fix-xunit-warnings branch October 29, 2018 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants