Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TestKit and TestKit.Xunit2 to the api spec #7060

Merged
merged 2 commits into from
Jan 12, 2024
Merged

Add TestKit and TestKit.Xunit2 to the api spec #7060

merged 2 commits into from
Jan 12, 2024

Conversation

yanpitangui
Copy link
Contributor

@yanpitangui yanpitangui commented Jan 12, 2024 •
edited by Aaronontheweb
Loading

Fixes #6468

Changes

This pr adds two tests, one for each project specified in the title.

Checklist

For significant changes, please ensure that the following have been completed (delete if not relevant):

Arkatufus
Arkatufus approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@Arkatufus Arkatufus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Arkatufus Arkatufus enabled auto-merge (squash) January 12, 2024 20:30
@Aaronontheweb Aaronontheweb added akka-testkit Akka.NET Testkit issues build system labels Jan 12, 2024
@Aaronontheweb
Copy link
Member

Well done @yanpitangui - LGTM

@Arkatufus Arkatufus merged commit 0782c7d into akkadotnet:dev Jan 12, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arkatufus Arkatufus Arkatufus approved these changes

Assignees
No one assigned
Labels
akka-testkit Akka.NET Testkit issues build system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TestKit and Xunit2.TestKit are not included inside the API approval test
3 participants
@yanpitangui @Aaronontheweb @Arkatufus