Suppress extremely chatty TimerScheduler debug messages #7102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aaronontheweb
requested changes
Feb 26, 2024
|
|
||
| public TimerScheduler(IActorContext ctx) | ||
| { | ||
| _ctx = ctx; | ||
| _log = _ctx.System.Log; | ||
| _logDebug = ctx.System.Settings.Config.GetBoolean("akka.actor.debug.log-timers"); |
There was a problem hiding this comment.
Eh, one wrinkle here - it's better to have this setting get pulled into the Settings class once rather than parsed by each and every actor that uses the scheduler. For processes with a large number of actors that overhead + allocations from the parser can become significant. It's not a big deal when running a small number of actors that use IWithTimers, but if you're running hundreds of thousands that can add up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
TimerSchedulerwill emit debug messages.TimerSchedulerdebug messages