Implement Sharding.Delivery bypass feature #7106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arkatufus
commented
Feb 28, 2024
| } | ||
| else | ||
| { | ||
| _log.Warning($"Message unhandled [{msg}]. If you need to pass this message to the consumer sharding entity actor, set \"akka.reliable-delivery.sharding.consumer-controller.allow-bypass\" to true"); |
There was a problem hiding this comment.
Log a warning when a message was unhandled, informing the user that they can allow this message to be forwarded if they set allow-bypass to true
Comment on lines
+289
to
+292
| # Allow arbitrary message to be directly sent to the customer actor, | ||
| # this lets you use custom handoff messages to be used along side with | ||
| # cluster sharding reliable delivery | ||
| allow-bypass = false |
There was a problem hiding this comment.
New HOCON settings
| settings: Settings.Value.WithRole(null), | ||
| messageExtractor: new MessageExtractor(), | ||
| allocationStrategy: ShardAllocationStrategy.LeastShardAllocationStrategy(absoluteLimit: 2, relativeLimit: 1.0), | ||
| handOffStopMessage: SlowStopConsumerEntity.Stop.Instance); |
There was a problem hiding this comment.
This would not work without the new allow-bypass feature
Changed `.Tell` to `.Forward`
Aaronontheweb
approved these changes
Feb 29, 2024
| settings: Settings.Value.WithRole(null), | ||
| messageExtractor: new MessageExtractor(), | ||
| allocationStrategy: ShardAllocationStrategy.LeastShardAllocationStrategy(absoluteLimit: 2, relativeLimit: 1.0), | ||
| handOffStopMessage: SlowStopConsumerEntity.Stop.Instance); |
src/contrib/cluster/Akka.Cluster.Sharding/Delivery/Internal/ShardingConsumerControllerImpl.cs
Outdated
Show resolved
Hide resolved
src/contrib/cluster/Akka.Cluster.Sharding/Delivery/Internal/ShardingConsumerControllerImpl.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7089
Changes
Implements a bypass mechanism for Akka.Cluster.Sharding.Delivery needed for custom sharding handoff stop to work under sharding delivery.
To turn this feature on, set "akka.reliable-delivery.sharding.consumer-controller.allow-bypass" to true.