fix race conditions with ReceivePersistentActorTests
#7194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Subscriptions to the `EventStream` need to happen _before_ the actor emitting events starts, otherwise we can end up in a scenario where everything works but the assertion fails.
Aaronontheweb
commented
May 22, 2024
| @@ -31,9 +31,9 @@ public void Given_persistent_actor_with_no_receive_command_specified_When_receiv | |||
| //Given | |||
| var pid = "p-1"; | |||
| WriteEvents(pid, 1, 2, 3); | |||
| var actor = Sys.ActorOf(Props.Create(() => new NoCommandActor(pid)), "no-receive-specified"); | |||
| Sys.EventStream.Subscribe(TestActor, typeof(UnhandledMessage)); | |||
There was a problem hiding this comment.
Need to subscribe to the EventStream first, so we don't end up with a race condition behind the scenes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Subscriptions to the
EventStreamneed to happen before the actor emitting events starts, otherwise we can end up in a scenario where everything works but the assertion fails.Checklist
For significant changes, please ensure that the following have been completed (delete if not relevant):