Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Akka.Actor.Serialization: remember to serialize envelope AND underlying type when using serialize-messages=on #7200

Conversation

Aaronontheweb
Copy link
Member

@Aaronontheweb Aaronontheweb commented May 23, 2024

Changes

Bug: need to serialize both the envelope and the underlying type when serialize-messages=on

We found an issue stemming from a change I made in by #7010 where the underlying IWrappedMessage envelope would get discarded when serialize-messages=on. The solution to this problem is to force serialization of the envelope AND the underlying type and return the product of both of those. Right now we are discarding the envelope by accident, which causes the DistributedPubSubMediator to be unable to process any messages when serialize-messages=on

Checklist

For significant changes, please ensure that the following have been completed (delete if not relevant):

need to serialize both the envelope and the underlying type when `serialize-messages=on`
@Aaronontheweb
Copy link
Member Author

Now that #7202 has been merged in, we should be good to go

@Aaronontheweb Aaronontheweb merged commit 8100d30 into akkadotnet:dev May 24, 2024
8 of 12 checks passed
@Aaronontheweb Aaronontheweb deleted the fix-SerializeMessages-DistributedPubSub branch May 24, 2024 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants