Improve traceability of ITimerMsg
#7262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is mostly a Phobos-oriented improvement, aimed at making it easier to keep track of scheduled metrics in systems that use `IWithTimer` heavily.
Aaronontheweb
commented
Jun 23, 2024
| @@ -41,36 +41,39 @@ public Timer(object key, object msg, bool repeat, int generation, ICancelable ta | |||
| } | |||
| } | |||
|
|
|||
| public interface ITimerMsg | |||
| public interface ITimerMsg : IWrappedMessage, INoSerializationVerificationNeeded | |||
There was a problem hiding this comment.
IWrappedMessage is how we can get access to the contents of the timer and record it via Phobos metrics.
| Key = key; | ||
| Generation = generation; | ||
| Owner = owner; | ||
| Message = message; |
There was a problem hiding this comment.
We're not even going to access this value directly in the main timer use-case, so none of that code path is affected.
All of these messages types are internal so there's no public API impact.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This is mostly a Phobos-oriented improvement, aimed at making it easier to keep track of scheduled metrics in systems that use
IWithTimerheavily. Specifically, we now include the content of the message being scheduled inside the payload so we can answer the question "what was scheduled?" without a lot of overhead.This doesn't affect the public API of Akka.NET at all.
Checklist
For significant changes, please ensure that the following have been completed (delete if not relevant):