Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ConfigServiceDiscovery to support multi-config #7271

Merged
merged 2 commits into from
Jun 28, 2024
Merged

Update ConfigServiceDiscovery to support multi-config #7271

merged 2 commits into from
Jun 28, 2024

Conversation

Arkatufus
Copy link
Contributor

Changes

  • Make ConfigServiceDiscovery constructor compatible with the new multi-config feature

Aaronontheweb
Aaronontheweb approved these changes Jun 28, 2024
View reviewed changes
Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aaronontheweb Aaronontheweb added akka-discovery Akka.Discovery-related issues configuration labels Jun 28, 2024
@Aaronontheweb Aaronontheweb added this to the 1.5.27 milestone Jun 28, 2024
@Aaronontheweb Aaronontheweb merged commit 399c548 into akkadotnet:dev Jun 28, 2024
12 checks passed
@Arkatufus Arkatufus mentioned this pull request Jul 3, 2024
Merged
@Aaronontheweb Aaronontheweb mentioned this pull request Jul 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aaronontheweb Aaronontheweb Aaronontheweb approved these changes

Assignees
No one assigned
Labels
akka-discovery Akka.Discovery-related issues configuration
Projects
None yet
Milestone
1.5.27
Development

Successfully merging this pull request may close these issues.
2 participants
@Arkatufus @Aaronontheweb