Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ClusterSingletonProxy fails to reacquire singleton actor #7315

Conversation

Arkatufus
Copy link
Contributor

@Arkatufus Arkatufus commented Aug 7, 2024

Fixes akkadotnet/Akka.Management#2490

Changes

  • Add MNTR regression test
  • Implement fix

@Arkatufus Arkatufus marked this pull request as draft August 7, 2024 18:52
@Arkatufus Arkatufus marked this pull request as ready for review August 7, 2024 18:59
Copy link
Contributor Author

@Arkatufus Arkatufus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self review

Comment on lines +149 to +150
// try to re-acquire singleton in-case this is caused by a lost lease condition
IdentifySingleton();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actual fix, just try to re-acquire immediately

@Aaronontheweb Aaronontheweb added this to the 1.5.28 milestone Aug 8, 2024
@Aaronontheweb Aaronontheweb added akka-cluster-tools akka-coordination Akka.Coordination package updates and materials labels Aug 8, 2024
Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aaronontheweb Aaronontheweb merged commit 5e7be3a into akkadotnet:dev Aug 8, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
akka-cluster-tools akka-coordination Akka.Coordination package updates and materials
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Singleton proxy with kubernetes lease does not recover when lease is reacquired
2 participants