Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multilang #93

Merged
Merged

Conversation

oshliaer
Copy link
Contributor

@oshliaer oshliaer commented Oct 24, 2019

This is related to #87

  • Add the translations menu list as a part of the main menu. On partials
  • Add the langs menu list as a part of the main menu. On partials
  • Basic i18n support
  • Add drop-down list wrapping
  • Translate the example site to Russian

🚸 Requires customization of the menu. Lists are not wrapped in a drop-down list. I need help for this.

Video example

screenrecord

How to debug
  1. Pull the PR branch
  2. Checkout
  3. cd ./
  4. Run hugo
$> cd ./exampleSite && rm -rf ./public && hugo serve --config ./config.toml --themesDir ./../.. --renderToDisk --disableFastRender

Signed-off-by: Alex Ivanov <ai@contributor.pw>
Signed-off-by: Alex Ivanov <ai@contributor.pw>
exampleSite/config.toml Outdated Show resolved Hide resolved
exampleSite/config.yaml Outdated Show resolved Hide resolved
@alex-shpak
Copy link
Owner

Thank you for work!
I have idea to place language switch either in the footer of page or next to title as globe icon.

I would ask you to do few changes prior to merge:

  • Please remove resources changes from PR. Especially resource folder in root.
  • Rename DefaultContentLanguage to defaultContentLanguage in config files

Signed-off-by: Alex Ivanov <ai@contributor.pw>
Signed-off-by: Alex Ivanov <ai@contributor.pw>
Signed-off-by: Alex Ivanov <ai@contributor.pw>
@oshliaer
Copy link
Contributor Author

oshliaer commented Oct 30, 2019

  • remove resources changes from PR. Especially resource folder in root.
  • Rename DefaultContentLanguage to defaultContentLanguage in config files

I have idea to place language switch either in the footer of page or next to title as globe icon.

This great! But I still can’t figure out how to make a pretty beautiful drop-down list like (for example) the button shortcode.

@alex-shpak alex-shpak changed the base branch from master to feature/multilang November 9, 2019 22:24
@alex-shpak
Copy link
Owner

Merging to feature/multilang

@alex-shpak alex-shpak merged commit a67a65a into alex-shpak:feature/multilang Nov 9, 2019
alex-shpak pushed a commit that referenced this pull request Nov 16, 2019
* Add i18n langs trans example
* partials
* Update sample site
* cc of variables of config
* Clean PR
* revert master data
@oshliaer oshliaer deleted the rusian-translation branch January 11, 2021 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants