For devtools a11y testing #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexvy86
commented
Jun 13, 2024
There was a problem hiding this comment.
The URL used here is the one provided by VSCode after exposing a port publicly in a Codespaces instance.
alexvy86
commented
Jun 13, 2024
Comment on lines
+39
to
+47
| function initializeTinyliciousClient(logger?: ITelemetryBaseLogger): TinyliciousClient { | ||
| console.log(`Initializing Tinylicious client...`); | ||
| return new TinyliciousClient({ | ||
| connection: { | ||
| port: 443, | ||
| domain: "https://alexvy86-super-doodle-j677467qg2pwvp-7070.preview.app.github.dev", | ||
| }, | ||
| logger, | ||
| }); |
There was a problem hiding this comment.
This is the kind of change needed on an app that uses TinyliciousClient. The URL should match the one used in the updates to server/routerlicious/packages/tinylicious/src/resourcesFactory.ts.
When I originally did this, devtools-example worked like that, but we've since moved it to use the more low-level approach of directly creating a loader, so this change doesn't work in this app anymore but I kept the merge conflict here to show what needs to be done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Shows which changes need to be made in order to run an example app using tinylicious in Codespaces, in a way that several people can collaborate in it.
This requires first building routerlicious in the repo (
pnpm i+pnpm run buildfromserver/routerlicious. The client app then uses the in-repo version of tinylicious which is updated here to work when exposed through the URL provided by VSCode when exposing a port publicly.If installing tinylicious from npm, one could also go to the js file that corresponds to the source file shown in this PR, and make the necessary updates there.
Reviewer Guidance
The review process is outlined on this wiki page.