Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various error when selecting/deselecting the payment method #1100

Closed
syjer opened this issue Aug 6, 2022 · 0 comments
Closed

Various error when selecting/deselecting the payment method #1100

syjer opened this issue Aug 6, 2022 · 0 comments
Assignees

Comments

@syjer
Copy link
Member

syjer commented Aug 6, 2022

Error 1:
Looks like we can save mollie+saferpay or stripe+saferpay when both handle credit cards, thus failing:

java.lang.IllegalStateException: Duplicate key CREDIT_CARD (attempted merging values alfio.controller.api.v2.model.PaymentProxyWithParameters@c4ab5de7 and alfio.controller.api.v2.model.PaymentProxyWithParameters
@73f40e94)
        at java.util.stream.Collectors.duplicateKeyException(Collectors.java:133) ~[?:?]

Fix at the PaymentManager.validateSelection level -> this is due to the fact that on one side, it present incomplete payment provider, on the other side, during the validation, it will filter out those incomplete, which then are discarded from the validation and are able to be selected anyway.

Error 2:
When adding and then removing all the payment methods, we save "" and thus fails a Enum.valueOf("") call.
To check getBlacklistedMethodsForReservation . edit: currently not able to validate it.: edit2 fixed in #1102 !

@syjer syjer self-assigned this Aug 6, 2022
syjer added a commit that referenced this issue Aug 6, 2022
syjer added a commit that referenced this issue Aug 6, 2022
cbellone pushed a commit that referenced this issue Aug 13, 2022
…nconfigured ones (#1101)

* when validating the payment provider for an event, don't filter out unconfigured ones, see error 1 in #1100

* refactor: reduce method visibility #1100
cbellone pushed a commit that referenced this issue Sep 17, 2022
…nconfigured ones (#1101)

* when validating the payment provider for an event, don't filter out unconfigured ones, see error 1 in #1100

* refactor: reduce method visibility #1100
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants