Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage additional service quantity #1308

Merged

Conversation

cbellone
Copy link
Member

@cbellone cbellone commented Dec 8, 2023

This PR:

@cbellone cbellone marked this pull request as ready for review December 8, 2023 18:20
@cbellone cbellone requested a review from syjer December 8, 2023 18:20
@syjer
Copy link
Member

syjer commented Dec 13, 2023

UI related improvement:

During the ticket selection flow:

  • better signaling about the additional options (add a title for the section "Selected additional options"? )
  • display description, as only the title may not be enough

During visualization of the ticket:

  • pdf should have the attached additional option
  • html view should also have (it's visible during the edit, but not on the list view and on the single view)
  • email (?)

Bug/issue:

In the admin, during the edit of an additional option:

java.lang.IllegalArgumentException: Cannot reduce available items to -1

When simply trying to change the name of:

Screenshot from 2023-12-13 11-09-50

Copy link

sonarcloud bot commented Dec 16, 2023

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

5 New issues
0 Security Hotspots
75.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@cbellone cbellone merged commit 1355106 into 2.0-M4-maintenance Dec 17, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants