idb(postgres): add protocol version check before writing to database. (…

…#1506)
algorand · Mar 15, 2023 · cf0074c · cf0074c
1 parent 922653f
commit cf0074c
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 0 deletions.
diff --git a/idb/postgres/postgres.go b/idb/postgres/postgres.go
@@ -175,6 +175,12 @@ func (db *IndexerDb) init(opts idb.IndexerDbOptions) (chan struct{}, error) {
 
 // AddBlock is part of idb.IndexerDb.
 func (db *IndexerDb) AddBlock(vb *itypes.ValidatedBlock) error {
+	protoVersion := protocol.ConsensusVersion(vb.Block.CurrentProtocol)
+	_, ok := config.Consensus[protoVersion]
+	if !ok {
+		return fmt.Errorf("unknown protocol (%s) detected, this usually means you need to upgrade", protoVersion)
+	}
+
 	block := vb.Block
 	round := block.BlockHeader.Round
 	db.log.Printf("adding block %d", round)

diff --git a/idb/postgres/postgres_test.go b/idb/postgres/postgres_test.go
@@ -6,8 +6,12 @@ import (
 	"time"
 
 	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+
+	sdk "github.com/algorand/go-algorand-sdk/v2/types"
 
 	"github.com/algorand/indexer/idb"
+	"github.com/algorand/indexer/types"
 )
 
 func Test_txnFilterOptimization(t *testing.T) {
@@ -54,3 +58,19 @@ func Test_txnFilterOptimization(t *testing.T) {
 		})
 	}
 }
+
+func Test_UnknownProtocol(t *testing.T) {
+	db := IndexerDb{}
+	protocol := "zzzzzzz"
+	err := db.AddBlock(&types.ValidatedBlock{
+		Block: sdk.Block{
+			BlockHeader: sdk.BlockHeader{
+				UpgradeState: sdk.UpgradeState{
+					CurrentProtocol: protocol,
+				},
+			},
+		},
+	})
+	require.ErrorContains(t, err, protocol)
+	require.ErrorContains(t, err, "you need to upgrade")
+}