Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: adding ParticipationUpdates to response #1215

Merged
merged 5 commits into from
Sep 13, 2022
Merged

Conversation

shiqizng
Copy link
Contributor

@shiqizng shiqizng commented Sep 7, 2022

Summary

Updated API spec to include ParticipationUpdates in the response for /v2/blocks/{round-number}

Test Plan

add a new test in handler_e2e

@shiqizng shiqizng changed the title adding ParticipationUpdates to block response adding ParticipationUpdates to response Sep 7, 2022
@shiqizng shiqizng changed the title adding ParticipationUpdates to response enhancement: adding ParticipationUpdates to response Sep 7, 2022
@shiqizng shiqizng added Enhancement New feature or request Team Lamprey labels Sep 7, 2022
Copy link
Contributor

@winder winder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Sep 9, 2022

Codecov Report

Merging #1215 (afea156) into develop (e19ec4b) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #1215      +/-   ##
===========================================
+ Coverage    60.85%   60.88%   +0.03%     
===========================================
  Files           52       52              
  Lines         8476     8488      +12     
===========================================
+ Hits          5158     5168      +10     
- Misses        2860     2861       +1     
- Partials       458      459       +1     
Impacted Files Coverage Δ
api/generated/common/routes.go 46.51% <ø> (ø)
api/generated/v2/routes.go 17.76% <ø> (ø)
api/handlers.go 75.48% <100.00%> (+0.30%) ⬆️
fetcher/fetcher.go 50.87% <0.00%> (-1.32%) ⬇️
api/pointer_utils.go 94.36% <0.00%> (+1.40%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants