Fix configuration of logger #1259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves #1246 Fixes order of configuration so that logger can be set properly
Codecov Report
@@ Coverage Diff @@
## conduit #1259 +/- ##
========================================
Coverage 60.13% 60.13%
========================================
Files 74 74
Lines 9910 9910
========================================
Hits 5959 5959
Misses 3435 3435
Partials 516 516 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
shiqizng
approved these changes
Oct 6, 2022
winder
approved these changes
Oct 7, 2022
AlgoStephenAkiki
deleted the
1246-logfile-parameter-in-config-file-is-ignored
branch
AlgoStephenAkiki
added a commit
that referenced
this pull request
Oct 7, 2022
Resolves #1246 Fixes order of configuration so that logger can be set properly
AlgoStephenAkiki
added a commit
that referenced
this pull request
Oct 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1246
Fixes order of configuration so that logger can be set properly
Will duplicate to develop once this is approved
Summary
Explain the goal of this change and what problem it is solving. Format this cleanly so that it may be used for a commit message, as your changes will be squash-merged.
Test Plan
How did you test these changes? Please provide the exact scenarios you tested in as much detail as possible including commands, output and rationale.