conduit: Add Conduit startup banner and fix default log level. #1372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1372 +/- ##
==========================================
Coverage ? 63.28%
==========================================
Files ? 76
Lines ? 10495
Branches ? 0
==========================================
Hits ? 6642
Misses ? 3292
Partials ? 561
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
winder
changed the title
shiqizng
approved these changes
Dec 12, 2022
winder
force-pushed
the
will/prerelease-banner
branch
from
d60a94e
to
08b8680
Compare
Eric-Warehime
approved these changes
Dec 12, 2022
AlgoStephenAkiki
approved these changes
Dec 12, 2022
|
@shiqizng yes. It should only defaults to hidden when running via Indexer, I was it would be OK because that configuration has had much more testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add a startup banner to Conduit. It prints to stdout and indicates that we're currently in a pre-release mode.
Optional configuration value to disable the banner. Indexer's automatically configured conduit disables the banner because that configuration has been tested much more thoroughly than other configurations.
Also fix the log-level setting.
Test Plan
New unit test.