API: Skip inner transaction fetching when possible. #1402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winder
requested review from
mciccarello,
Eric-Warehime,
shiqizng and
AlgoStephenAkiki
shiqizng
approved these changes
Jan 4, 2023
AlgoStephenAkiki
approved these changes
Jan 4, 2023
winder
force-pushed
the
will/txn-optimization
branch
from
812dd71
to
e401443
Compare
winder
changed the title
Codecov Report
@@ Coverage Diff @@
## hotfix/2.15.1 #1402 +/- ##
=================================================
+ Coverage 65.03% 65.07% +0.03%
=================================================
Files 52 52
Lines 8315 8333 +18
=================================================
+ Hits 5408 5423 +15
- Misses 2433 2435 +2
- Partials 474 475 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Eric-Warehime
approved these changes
Jan 4, 2023
This was referenced Jan 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If contiguous transactions are being returned, there is no need to fetch the inner transactions. This is significantly easier for postgres to process and in some cases yields significantly less redundant data.
Test Plan
New unit tests. Manually tested pagination comparing results before and after this change.