filter-processor: Remove reflection #1468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Don't add entries for tags in the middle. * Add type casting. * Add manual ignores for things like signatures.
Codecov Report
@@ Coverage Diff @@
## develop #1468 +/- ##
===========================================
+ Coverage 64.69% 65.71% +1.01%
===========================================
Files 84 84
Lines 11504 11467 -37
===========================================
+ Hits 7442 7535 +93
+ Misses 3493 3364 -129
+ Partials 569 568 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
shiqizng
approved these changes
Feb 16, 2023
conduit/plugins/processors/filterprocessor/expression/expression.go
Outdated
Show resolved
Hide resolved
conduit/plugins/processors/filterprocessor/expression/expression.go
Outdated
Show resolved
Hide resolved
Eric-Warehime
approved these changes
Feb 17, 2023
Comment on lines
+404
to
+412
| func BenchmarkSearch(b *testing.B) { | ||
| exp, err := MakeExpression(EqualToFilter, "10", "") | ||
| require.NoError(b, err) | ||
|
|
||
| b.ResetTimer() | ||
| for i := 0; i < b.N; i++ { | ||
| exp.Search("11") | ||
| } | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Next round of changes after #1463
ExactFilterandEqualToFilterTest Plan
New unit tests and existing regression tests.