alerting: Slack #lamprey-builds Channel
#1524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzaffi
commented
May 12, 2023
tzaffi
added
Enhancement
tzaffi
changed the title
#lamprey-builds Channel#lamprey-builds Channel
tzaffi
changed the title
#lamprey-builds Channel#lamprey-builds Channel
tzaffi
changed the title
#lamprey-builds Channel#lamprey-builds Channel
algobarb
reviewed
May 12, 2023
tzaffi
commented
May 12, 2023
| @@ -54,7 +54,7 @@ jobs: | |||
| - install_linter | |||
| - run_tests | |||
| # Change this to run_e2e_tests once we have stable algod binaries containing delta APIs | |||
| - run_e2e_tests_nightly | |||
| # - run_e2e_tests_nightly | |||
There was a problem hiding this comment.
Chicken and egg problem here. I can't re-route the slack messaging until I fix the test. But the test is broken and getting slacked to the wrong channel. I've added a TODO to #1521 :
Codecov Report
@@ Coverage Diff @@
## develop #1524 +/- ##
========================================
Coverage 70.35% 70.35%
========================================
Files 40 40
Lines 8135 8136 +1
========================================
+ Hits 5723 5724 +1
Misses 1982 1982
Partials 430 430
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
tzaffi
requested review from
algobarb,
Eric-Warehime and
shiqizng
and removed request for
a team
Eric-Warehime
approved these changes
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Indexer is owned by Team Lamprey. Therefore, alerts of indexer build failures ought to be routed to a Lamprey-specific slack channel instead of
#dev-alerts.Issues
#1521
Test Plan
CI
You can see that the configuration works by looking at recent notifications inside of
#lamprey-builds.